Re: [PATCH] i2c: rcar: fix NACK handling when being a target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 15, 2025 at 01:36:23PM +0100, Wolfram Sang wrote:
> When this controller is a target, the NACK handling had two issues.
> First, the return value from the backend was not checked on the initial
> WRITE_REQUESTED. So, the driver missed to send a NACK in this case.
> Also, the NACK always arrives one byte late on the bus, even in the
> WRITE_RECEIVED case. This seems to be a HW issue. We should then not
> rely on the backend to correctly NACK the superfluous byte as well. Fix
> both issues by introducing a flag which gets set whenever the backend
> requests a NACK and keep sending it until we get a STOP condition.
> 
> Fixes: de20d1857dd6 ("i2c: rcar: add slave support")
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Applied to for-current, thanks!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux