Re: [PATCH v4 8/9] i2c: riic: Use predefined macro and simplify clock tick calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, Prabhakar <prabhakar.csengg@xxxxxxxxx>, Chris Brandt <chris.brandt@xxxxxxxxxxx>, Andi Shyti <andi.shyti@xxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Andy Shevchenko <andy.shevchenko@xxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, linux-renesas-soc@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Biju Das <biju.das.jz@xxxxxxxxxxxxxx>, Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>, Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v4 8/9] i2c: riic: Use predefined macro and simplify clock tick calculation
From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Date: Sun, 12 Jan 2025 16:29:03 +0200
In-reply-to: <Z3-ZsKyZ7aGnpjuQ@shikoro>
References: <20250103091900.428729-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20250103091900.428729-9-prabhakar.mahadev-lad.rj@bp.renesas.com> <Z3-ZsKyZ7aGnpjuQ@shikoro>

On Thu, Jan 9, 2025 at 11:41 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > +#include <vdso/time64.h>
>
> Hmmm, what about using 'linux/time.h' instead and relying that it does
> the right thing?

+1.

> Nice cleanup otherwise!

+1.

-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH v4 0/9] i2c: riic: driver cleanup and improvements
  - From: Prabhakar
- [PATCH v4 8/9] i2c: riic: Use predefined macro and simplify clock tick calculation
  - From: Prabhakar
- Re: [PATCH v4 8/9] i2c: riic: Use predefined macro and simplify clock tick calculation
  - From: Wolfram Sang

Prev by Date: Re: [PATCH v4 0/9] i2c: riic: driver cleanup and improvements
Next by Date: Re: [PATCH v4 0/9] i2c: riic: driver cleanup and improvements
Previous by thread: Re: [PATCH v4 8/9] i2c: riic: Use predefined macro and simplify clock tick calculation
Next by thread: [PATCH v4 9/9] i2c: riic: Add `riic_bus_barrier()` to check bus availability
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]