Hi Geert,
Thanks for your review.
On 2025-01-10 11:44:21 +0100, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Thu, Jan 9, 2025 at 1:55 PM Niklas Söderlund
> <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > Add device nodes for the FCPVX instances on R-Car V3U.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> i.e. will queue in renesas-devel for v6.15.
>
> > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > @@ -2890,6 +2890,42 @@ port@1 {
> > };
> > };
> >
> > + fcpvx0: fcp@fedb0000 {
>
> I think it makes sense to move these next to the existing fcp nodes.
> If you agree, I can do that while applying.
The rational here was I sorted it based on addresses, but I'm fine
either way. If you can fix this when applying I would be grateful,
thanks!
Same for patch 2/2.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Kind Regards,
Niklas Söderlund
