On Tue, Jan 7, 2025 at 1:26 PM <kingdix10@xxxxxx> wrote:
>
> From: King Dix <kingdix10@xxxxxx>
>
> When using devm_request_mem_region to request a resource, if the passed
> variable is a stack string variable, it will lead to an oops issue when
> executing the command cat /proc/iomem.
>
> Fix this by replacing outbound_name with the name of the previously
> requested resource.
>
You missed adding below which I had mentioned on v2..
Fixes: 2a6d0d63d999 ("PCI: rcar: Add endpoint mode support")
> Signed-off-by: King Dix <kingdix10@xxxxxx>
..and also:
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
This patch has not been CC'd to any list not sure the maintainers will
pick this up. Please refer to link [0] on how to pick the right
recipients for your patch.
[0] https://www.kernel.org/doc/html/v5.1/process/submitting-patches.html#select-the-recipients-for-your-patch
Cheers,
Prabhakar
> ---
> Changes in v3:
> - Fix the spelling issue in the comment.
> Changes in v2:
> - Fix the code indentation issue.
> ---
> drivers/pci/controller/pcie-rcar-ep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
> index 047e2cef5afc..c5e0d025bc43 100644
> --- a/drivers/pci/controller/pcie-rcar-ep.c
> +++ b/drivers/pci/controller/pcie-rcar-ep.c
> @@ -107,7 +107,7 @@ static int rcar_pcie_parse_outbound_ranges(struct rcar_pcie_endpoint *ep,
> }
> if (!devm_request_mem_region(&pdev->dev, res->start,
> resource_size(res),
> - outbound_name)) {
> + res->name)) {
> dev_err(pcie->dev, "Cannot request memory region %s.\n",
> outbound_name);
> return -EIO;
> --
> 2.43.0
>
