Re: [PATCH 2/5] net: renesas: rswitch: fix leaked pointer on error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Why not move the assignment down, then? After we have successfully
mapped all entries?

Just realized that moving assignment below the loop will open a race window. DT field is set inside the loop, and once it is set, completion interrupt becomes theoretically possible.

Furthermore, realized that existing code already has a race. Interrupt can happen after DT wield was updated but before cur is updated. Then, with the completion code won't check the entry (up to a new interrupt, that can theoretically not happen).

Will fix in the updated patches.

Nikita




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux