Re: [PATCH 0/5] arm64: renesas: Add R8A779G3 White Hawk Single support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

On Wed, Dec 4, 2024 at 1:56 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> > This patch series adds support for the Renesas R-Car V4H ES3.0 (R8A779G3)
> > SoC on the Renesas White Hawk Single board.  R-Car V4H ES3.0 (R8A779G3)
> > is an updated version of R-Car V4H (R8A779G0).
> >
> > I intend to queue these in renesas-devel for v6.14.
> > Thanks for your comments!
>
> Thank you for the patch-set. For all patches
>
> Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> But small nitpick is that R8A779G2 is not only for ES2.0 but for ES2.x

I didn't add any occurrences of "ES2.0" in this series ;-)

I did consider adding comments to the SoC-specific compatible values
in Documentation/devicetree/bindings/soc/renesas/renesas.yaml

-              - renesas,r8a779g2
-              - renesas,r8a779g3
+              - renesas,r8a779g2 # ES2.x
+              - renesas,r8a779g3 # ES3.0

but decided against doing so, as "ES3.0" would become stale as soon
as Renesas releases "ES3.1". Alternatively, I could use "ES3.x"
immediately.

What do you think?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux