On 12/2/2024 5:49 AM, Nikita Yushchenko wrote:
> This field is set but never used.
>
> GWCA is rswitch CPU interface module which connects rswitch to the
> host over AXI bus. Speed of the switch ports is not anyhow related to
> GWCA operation.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>
> ---
I tried grepping the code and didn't find any other users either.
Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>
This one also could be a cleanup that goes to next since there doesn't
appear to be any user visible bug.
> drivers/net/ethernet/renesas/rswitch.c | 3 ---
> drivers/net/ethernet/renesas/rswitch.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index 5980084d9211..bef344e0b1fd 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -1902,9 +1902,6 @@ static int rswitch_device_alloc(struct rswitch_private *priv, unsigned int index
> if (err < 0)
> goto out_get_params;
>
> - if (rdev->priv->gwca.speed < rdev->etha->speed)
> - rdev->priv->gwca.speed = rdev->etha->speed;
> -
> err = rswitch_rxdmac_alloc(ndev);
> if (err < 0)
> goto out_rxdmac;
> diff --git a/drivers/net/ethernet/renesas/rswitch.h b/drivers/net/ethernet/renesas/rswitch.h
> index 72e3ff596d31..303883369b94 100644
> --- a/drivers/net/ethernet/renesas/rswitch.h
> +++ b/drivers/net/ethernet/renesas/rswitch.h
> @@ -993,7 +993,6 @@ struct rswitch_gwca {
> DECLARE_BITMAP(used, RSWITCH_MAX_NUM_QUEUES);
> u32 tx_irq_bits[RSWITCH_NUM_IRQ_REGS];
> u32 rx_irq_bits[RSWITCH_NUM_IRQ_REGS];
> - int speed;
> };
>
> #define NUM_QUEUES_PER_NDEV 2
