Hi Prabhakar, On Wed, Nov 27, 2024 at 1:41 PM Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > On Wed, Nov 27, 2024 at 9:54 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Tue, Nov 5, 2024 at 12:24 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > Update `rzv2h_cpg_attach_dev` to prevent external clocks not tied to the > > > power domain from being managed by Runtime PM. This ensures that only > > > clocks originating from the domain are controlled, thereby avoiding > > > unintended handling of external clocks. > > > > > > Additionally, introduce a `no_pm` flag in `mod_clock` and `rzv2h_mod_clk` > > > structures to exclude specific clocks from Runtime PM when needed. Some > > > clocks, such as those in the CRU block, require unique enable/disable > > > sequences that are incompatible with standard Runtime PM. For example, > > > the CSI-2 D-PHY clock initialization requires toggling individual clocks, > > > making Runtime PM unsuitable. > > > > > > The helper function `rzv2h_cpg_is_pm_clk()` checks whether a clock should > > > be managed by Runtime PM based on this `no_pm` flag. New macros, such as > > > `DEF_MOD_NO_PM`, allow straightforward declaration of clocks that bypass > > > PM. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > --- > > > v1->v2 > > > - Updated code to skip external clocks to be controlled from runtime PM > > > - Updated id range check > > > - Updated commit message > > Note that this series conflicts with "[PATCH 00/12] Add support for > > Renesas RZ/G3E SoC and SMARC-EVK platform", which you are probably > > already aware of. > > > > [1] https://lore.kernel.org/all/20241122124558.149827-1-biju.das.jz@xxxxxxxxxxxxxx/ > > > Yep, I'll ask Biju kindly to rebase the changes on top of v3 while he > sends v2. Or do you want me to rebase on the above? I guess your series is closer to the point of acceptance. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
