Re: [PATCH 1/2] thermal: rcar_gen3: Use lowercase hex constants

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Niklas,

On Sat, Nov 16, 2024 at 6:30 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> The style of the driver is to use lowercase hex constants, correct the
> few outlines.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/thermal/renesas/rcar_gen3_thermal.c
> +++ b/drivers/thermal/renesas/rcar_gen3_thermal.c
> @@ -57,11 +57,11 @@
>  /* THSCP bits */
>  #define THSCP_COR_PARA_VLD     (BIT(15) | BIT(14))
>
> -#define CTEMP_MASK     0xFFF
> +#define CTEMP_MASK     0xfff
>
>  #define MCELSIUS(temp) ((temp) * 1000)
> -#define GEN3_FUSE_MASK 0xFFF
> -#define GEN4_FUSE_MASK 0xFFF
> +#define GEN3_FUSE_MASK 0xfff
> +#define GEN4_FUSE_MASK 0xfff
>
>  #define TSC_MAX_NUM    5

LGTM, but you missed a few:

$ git grep "\<0x.*[A-Z]" -- drivers/thermal/renesas/rcar_gen3_thermal.c
drivers/thermal/renesas/rcar_gen3_thermal.c:#define REG_GEN3_IRQCTL
         0x0C
drivers/thermal/renesas/rcar_gen3_thermal.c:#define REG_GEN3_IRQTEMP3   0x1C
drivers/thermal/renesas/rcar_gen3_thermal.c:#define REG_GEN4_THSFMON15  0x1BC
drivers/thermal/renesas/rcar_gen3_thermal.c:#define REG_GEN4_THSFMON16  0x1C0
drivers/thermal/renesas/rcar_gen3_thermal.c:#define REG_GEN4_THSFMON17  0x1C4

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds