On Thu, Nov 14, 2024 at 08:04:40PM -0800, Randy Dunlap wrote: > Hi robot, > > On 11/8/24 4:27 AM, kernel test robot wrote: > > Hi Randy, > > > > First bad commit (maybe != root cause): > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > head: 906bd684e4b1e517dd424a354744c5b0aebef8af > > commit: 51084f89d687e14d96278241e5200cde4b0985c7 fbdev: sh7760fb: allow modular build > > The same warnings happen without this patch applied, so I suggest that you > backtrack to the commit that is listed near the end of your email. Thanks so much. :) Got it, thanks for the info. We will ignore this commit to avoid false report and adjust bisect process to capture the actual one. Thanks > > > date: 7 months ago > > config: sh-randconfig-r132-20241108 (https://download.01.org/0day-ci/archive/20241108/202411082014.qSQ9A5ho-lkp@xxxxxxxxx/config) > > compiler: sh4-linux-gcc (GCC) 14.2.0 > > reproduce: (https://download.01.org/0day-ci/archive/20241108/202411082014.qSQ9A5ho-lkp@xxxxxxxxx/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202411082014.qSQ9A5ho-lkp@xxxxxxxxx/ > > > > sparse warnings: (new ones prefixed by >>) > >>> drivers/video/fbdev/sh7760fb.c:363:31: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void *cpu_addr @@ got char [noderef] __iomem *screen_base @@ > > drivers/video/fbdev/sh7760fb.c:363:31: sparse: expected void *cpu_addr > > drivers/video/fbdev/sh7760fb.c:363:31: sparse: got char [noderef] __iomem *screen_base > >>> drivers/video/fbdev/sh7760fb.c:423:27: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char [noderef] __iomem *screen_base @@ got void *[assigned] fbmem @@ > > drivers/video/fbdev/sh7760fb.c:423:27: sparse: expected char [noderef] __iomem *screen_base > > drivers/video/fbdev/sh7760fb.c:423:27: sparse: got void *[assigned] fbmem > > drivers/video/fbdev/sh7760fb.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...): > > include/linux/page-flags.h:242:46: sparse: sparse: self-comparison always evaluates to false > > include/linux/page-flags.h:242:46: sparse: sparse: self-comparison always evaluates to false > > > > vim +363 drivers/video/fbdev/sh7760fb.c > > > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 354 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 355 static void sh7760fb_free_mem(struct fb_info *info) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 356 { > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 357 struct sh7760fb_par *par = info->par; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 358 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 359 if (!info->screen_base) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 360 return; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 361 > > 8404e56f4bc1d1 drivers/video/fbdev/sh7760fb.c Thomas Zimmermann 2023-06-13 362 dma_free_coherent(info->device, info->screen_size, > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 @363 info->screen_base, par->fbdma); > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 364 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 365 par->fbdma = 0; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 366 info->screen_base = NULL; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 367 info->screen_size = 0; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 368 } > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 369 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 370 /* allocate the framebuffer memory. This memory must be in Area3, > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 371 * (dictated by the DMA engine) and contiguous, at a 512 byte boundary. > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 372 */ > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 373 static int sh7760fb_alloc_mem(struct fb_info *info) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 374 { > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 375 struct sh7760fb_par *par = info->par; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 376 void *fbmem; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 377 unsigned long vram; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 378 int ret, bpp; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 379 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 380 if (info->screen_base) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 381 return 0; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 382 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 383 /* get color info from register value */ > > f08c6c53b8e157 drivers/video/fbdev/sh7760fb.c Thomas Zimmermann 2023-06-13 384 ret = sh7760fb_get_color_info(info, par->pd->lddfr, &bpp, NULL); > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 385 if (ret) { > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 386 printk(KERN_ERR "colinfo\n"); > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 387 return ret; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 388 } > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 389 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 390 /* min VRAM: xres_min = 16, yres_min = 1, bpp = 1: 2byte -> 1 page > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 391 max VRAM: xres_max = 1024, yres_max = 1024, bpp = 16: 2MB */ > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 392 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 393 vram = info->var.xres * info->var.yres; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 394 if (info->var.grayscale) { > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 395 if (bpp == 1) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 396 vram >>= 3; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 397 else if (bpp == 2) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 398 vram >>= 2; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 399 else if (bpp == 4) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 400 vram >>= 1; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 401 } else if (bpp > 8) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 402 vram *= 2; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 403 if ((vram < 1) || (vram > 1024 * 2048)) { > > 46d86f3b3b1d22 drivers/video/fbdev/sh7760fb.c Thomas Zimmermann 2023-06-13 404 fb_dbg(info, "too much VRAM required. Check settings\n"); > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 405 return -ENODEV; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 406 } > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 407 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 408 if (vram < PAGE_SIZE) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 409 vram = PAGE_SIZE; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 410 > > 8404e56f4bc1d1 drivers/video/fbdev/sh7760fb.c Thomas Zimmermann 2023-06-13 411 fbmem = dma_alloc_coherent(info->device, vram, &par->fbdma, GFP_KERNEL); > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 412 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 413 if (!fbmem) > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 414 return -ENOMEM; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 415 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 416 if ((par->fbdma & SH7760FB_DMA_MASK) != SH7760FB_DMA_MASK) { > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 417 sh7760fb_free_mem(info); > > 8404e56f4bc1d1 drivers/video/fbdev/sh7760fb.c Thomas Zimmermann 2023-06-13 418 dev_err(info->device, "kernel gave me memory at 0x%08lx, which is" > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 419 "unusable for the LCDC\n", (unsigned long)par->fbdma); > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 420 return -ENOMEM; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 421 } > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 422 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 @423 info->screen_base = fbmem; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 424 info->screen_size = vram; > > 537a1bf059fa31 drivers/video/sh7760fb.c Krzysztof Helt 2009-06-30 425 info->fix.smem_start = (unsigned long)info->screen_base; > > 537a1bf059fa31 drivers/video/sh7760fb.c Krzysztof Helt 2009-06-30 426 info->fix.smem_len = info->screen_size; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 427 > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 428 return 0; > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 429 } > > 4a25e41831ee85 drivers/video/sh7760fb.c Nobuhiro Iwamatsu 2008-07-23 430 > > > > :::::: The code at line 363 was first introduced by commit > > :::::: 4a25e41831ee851c1365d8b41decc22493b18e6d video: sh7760fb: SH7760/SH7763 LCDC framebuffer driver > > This one ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > :::::: TO: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@xxxxxxxxxxx> > > :::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > > > > -- > ~Randy > >
