On Tue, Oct 15, 2024 at 6:48 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > > Move the PM domain power on in rzg2l_cpg_pd_setup(). With this the > previously always-on power domains got > struct generic_pm_domain::{power_on, power_off} populated (and > registered with simple_qos_governor if #power-domain-cells = <1> and > with pm_domain_always_on_gov if #power-domain-cells = <0>). The values for > struct generic_pm_domain::{power_on, power_off} are now populated for > all registered domains but used by core only for the domains that can > use them (the PM domain should be non always-on and registered with > simple_qos_governor). Moreover, the power on/off functions check if the > mstop support is valid. The mstop is populated only by the RZ/G3S > initialization code at the moment. > > This approach was chosen to keep the code simple and use the same code > across different implementations. There should be no issues with this > approach as the always on domains are registered with GENPD_FLAG_ALWAYS_ON > and the PM domain core takes care of it. > > This approach allows doing further cleanups on the rzg2l_cpg power domain > registering code that will be handled by the next commit. > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > --- > > Changes in v4: > - call rzg2l_cpg_power_on() unconditionally > - drop the governor parameter of rzg2l_cpg_pd_setup() and decide the > governor based on always_on flag > - collected tags Thanks, will queue in renesas-clk for v6.13. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds