On Mon, Oct 21, 2024 at 09:32:37AM +0200, Krzysztof Kozlowski wrote: > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/r9a08g045-cpg.h> > > + #include <dt-bindings/clock/renesas,r9a08g045-vbattb.h> > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + > > + clock-controller@1005c000 { > > + compatible = "renesas,r9a08g045-vbattb"; > > + reg = <0x1005c000 0x1000>; > > + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb_xtal>; > > + clock-names = "bclk", "rtx"; > > + assigned-clocks = <&vbattb VBATTB_MUX>; > > + assigned-clock-parents = <&vbattb VBATTB_XC>; > > Why are you configuring internal clocks to internal parents? That's part > internal to this device, not DTS... or at least some explanation would > be useful.