Hi Laurent, Thank you for the review. On Tue, Oct 15, 2024 at 11:22 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Fri, Oct 11, 2024 at 06:30:40PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > `WARN_ON(!fmt)` check in `rzg2l_cru_format_bytesperline()` is unnecessary > > because the `rzg2l_cru_format_align()` function ensures that a valid > > `pixelformat` is set before calling `rzg2l_cru_format_bytesperline()`. As > > a result, `rzg2l_cru_format_from_pixel()` is guaranteed to return a > > non-NULL value, making the check redundant. > > > > Additionally, the return type of `rzg2l_cru_format_bytesperline()` is > > `u32`, but the code returned `-EINVAL`, a negative value. This mismatch is > > now resolved by removing the invalid error return path. > > s/now /now / > Oops, I will drop the extra space. Cheers, Prabhakar
