Re: [net-next] net: ravb: Only advertise Rx/Tx timestamps if hardware supports it

[Paul Barker <paul.barker.ct@xxxxxxxxxxxxxx>]

On 05/10/2024 13:14, Niklas Söderlund wrote:
> Recent work moving the reporting of Rx software timestamps to the core
> [1] highlighted an issue where hardware time stamping where advertised
> for the platforms where it is not supported.
> 
> Fix this by covering advertising support for hardware timestamps only if
> the hardware supports it. Due to the Tx implementation in RAVB software
> Tx timestamping is also only considered if the hardware supports
> hardware timestamps. This should be addressed in future, but this fix
> only reflects what the driver currently implements.
> 
> 1. Commit 277901ee3a26 ("ravb: Remove setting of RX software timestamp")
> 
> Fixes: 7e09a052dc4e ("ravb: Exclude gPTP feature support for RZ/G2L")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

On RZ/G2UL, which doesn't support HW timestamping, before this patch:

    $ ethtool -T eth0
    Time stamping parameters for eth0:
    Capabilities:
            hardware-transmit
            software-transmit
            hardware-receive
            software-receive
            software-system-clock
            hardware-raw-clock
    PTP Hardware Clock: 0
    Hardware Transmit Timestamp Modes:
            off
            on
    Hardware Receive Filter Modes:
            none
            all
            ptpv2-l2-event

After this patch:

    $ ethtool -T eth0
    Time stamping parameters for eth0:
    Capabilities:
            software-receive
            software-system-clock
    PTP Hardware Clock: none
    Hardware Transmit Timestamp Modes: none
    Hardware Receive Filter Modes: none

Thanks Niklas!

Reviewed-by: Paul Barker <paul.barker.ct@xxxxxxxxxxxxxx>
Tested-by: Paul Barker <paul.barker.ct@xxxxxxxxxxxxxx>

-- 
Paul Barker

Attachment: OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature