Hi Wolfram, On Sat, Sep 28, 2024 at 11:30 AM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > Luckily, I still had an MMC card lying around. Works fine. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts > +++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts > @@ -88,6 +88,15 @@ led2 { > gpios = <&port4 11 GPIO_ACTIVE_LOW>; > }; > }; > + > + cvcc2: regulator-mmc { > + compatible = "regulator-fixed"; > + regulator-name = "CVcc2"; Odd case. "Cvcc2"? > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; The regulator is not always-on, but controlled through the MMC CD signal. > + }; > }; The rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds