Hi Wolfram Sang, > -----Original Message----- > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Sent: Monday, September 30, 2024 8:25 PM > Subject: Re: [PATCH 1/3] dmaengine: sh: rz-dmac: handle configs where one address is zero > > > > Now both code paths are identical, not sure may be introducing a > > helper by passing channel, CHCFG_FILL_*_MASK and *_addr_width will > > save some code?? > > I had a look and I don't think so because we'd need to pass so many parameters to the helper, that it > doesn't really save anything, I'd say. OK, fine by me. I just meant to avoid code duplication as it is identical blocks. Current changes are tested with RZ/G2L on with RSPI and SSI interfaces. So, Tested-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> Cheers, Biju
