Hi Marc, Thanks for your feedback. > From: Marc Zyngier <maz@xxxxxxxxxx> > Sent: Monday, September 30, 2024 4:50 PM > To: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> > Subject: Re: [PATCH] irqchip/renesas-rzg2l: Fix missing put_device > > On Mon, 30 Sep 2024 15:55:39 +0100, > Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> wrote: > > > > rzg2l_irqc_common_init calls of_find_device_by_node, but the > > corresponding put_device call is missing. > > > > Make sure we call put_device both when failing and when succeeding. > > What sort of lifetime are you trying to enforce? Function rzg2l_irqc_common_init uses pdev->dev until its very end. My understanding is that we should decrement the reference counter once we are fully done with it. Is my understanding correct? Thanks, Fab > > It looks to me that you'd be better off doing *one* device_put() right after you have found the parent > domain, but that completely depends on the above. > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible.
