> > - dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx, > > - host->chan_rx); > > This was not a real success indicator, which could indeed confuse > people, but an obfuscated NULL-pointer still prints as NULL, right? Well... > > > if (!host->chan_tx || !host->chan_rx || > > sh_mmcif_dma_slave_config(host, host->chan_tx, DMA_MEM_TO_DEV) || > > sh_mmcif_dma_slave_config(host, host->chan_rx, DMA_DEV_TO_MEM)) > > goto error; > > > > + dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx, > > + host->chan_rx); > > This means we no longer see a debug message in case only one DMA > channel could be requested, thus requiring manual addition of more code > to find out what was really wrong? ... you can simply enable basic DMA debugging to find this out. I don't see value in adding a separate debug printout in the driver.
Attachment:
signature.asc
Description: PGP signature
