Re: [PATCH v2 03/16] media: platform: rzg2l-cru: rzg2l-csi2: Mark sink and source pad with MUST_CONNECT flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

Thank you for the review.

On Fri, Sep 27, 2024 at 11:24 PM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Tue, Sep 10, 2024 at 06:53:44PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Mark the sink and source pad with the MEDIA_PAD_FL_MUST_CONNECT flag to
> > ensure pipeline validation fails if it is not connected.
>
> The MUST_CONNECT flag only affects sink pads. That's not documented
> though, and it seems that most drivers using the flag sets it on both
> sink and source pads. That's probably a good practice, and the fact that
> the flag is only checked for sink pads is more of an implementation
> detail. This patch is thus fine.
>
Agreed.

> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
>
> However, I think you should then set the flag on the source pad of the
> IP entity in patch 02/16. You can keep my Rb.
>
Sure, I'll add this flag in v3.

Cheers,
Prabhakar





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux