Re: [PATCH] ASoC: dt-bindings: renesas,rsnd: correct reg-names for R-Car Gen1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram

> The device at 0xffd90000 is named SRU, both in the datasheet and SoC
> DTSI. Fix the typo in the bindings to avoid the false positive report:
> 
>   sound@ffd90000: reg-names:0: 'sru' is not one of ['scu', 'ssi', 'adg']
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 3bc93c59535e..6d0d1514cd42 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -302,7 +302,7 @@ allOf:
>          reg-names:
>            items:
>              enum:
> -              - scu
> +              - sru
>                - ssi
>                - adg
>    # for Gen2/Gen3

Thank you the patch.

"sru" is old naming which was used for Gen1 only. It is called as "scu"
after Gen2, and driver is assuming it.
But sound driver doesn't support SRU(SCU) for Gen1, but this setting was
needed because driver get resource by using ID (this was needed to for
Gen2/Gen3 compatibility).

Around Gen4 support, driver gets resource by using "reg-names", "sru"
setting itself is no longer needed on SoC DTSI, but fixup Doc side is
good idea.

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Thank you for your help !!

Best regards
---
Kuninori Morimoto




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux