Hi Niklas,
On Mon, Aug 26, 2024 at 4:44 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> Add the Gen4 family compatible. This will be used instead of a SoC
> specific compatible for the new Gen4 SoC V4M. Two Gen4 boards (V3U and
> V4H) have already been added prior and their bindings need to be kept
> for backward compatibility.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> * Changes since v1
> - Reworked to add a family compatible instead of V4M specific one.
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> --- a/drivers/media/platform/renesas/rcar-isp.c
> +++ b/drivers/media/platform/renesas/rcar-isp.c
> @@ -429,8 +429,11 @@ static int risp_probe_resources(struct rcar_isp *isp,
> }
>
> static const struct of_device_id risp_of_id_table[] = {
> + /* Keep to be compatible with old DTS files. */
> { .compatible = "renesas,r8a779a0-isp" },
> + /* Keep to be compatible with old DTS files. */
> { .compatible = "renesas,r8a779g0-isp" },
Nit: perhaps a single comment "/* Keep above for compatibility with
old DTB files */" here?
> + { .compatible = "renesas,rcar-gen4-isp" },
> { /* sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, risp_of_id_table);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
