Hejssan! On Tue, Aug 27, 2024 at 07:57:35PM +0200, Niklas Söderlund wrote: > Hej Sakari, > > Tack för feedback. Var så god! > > > @@ -181,7 +186,8 @@ static void max96712_pattern_enable(struct max96712_priv *priv, bool enable) > > > } > > > > > > /* PCLK 75MHz. */ > > > - max96712_write(priv, 0x0009, 0x01); > > > + if (!priv->max96724) > > > + max96712_write(priv, 0x0009, 0x01); > > > > It'd be nice to have a macro for this, espeically now that the driver > > supports more than one chip. > > What do you mean by macro? To test for priv->max96724, a define for the > register name or something else? Ah, I meant 0x0009 and preferrably 0x01 as well. -- Hälsningar, Sakari Ailus