> -----Original Message----- > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Sent: Friday, August 23, 2024 11:51 AM > To: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski > <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Magnus Damm > <magnus.damm@xxxxxxxxx>; linux-sound@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-renesas- > soc@xxxxxxxxxxxxxxx; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; biju.das.au > <biju.das.au@xxxxxxxxx> > Subject: RE: [PATCH 2/3] arm64: dts: renesas: rzg2l-smarc: Enable HDMI audio > > Hi All, > > > -----Original Message----- > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Sent: Friday, August 23, 2024 10:59 AM > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: rzg2l-smarc: Enable HDMI > > audio > > > > Hi Biju, > > > > On Thu, Jul 25, 2024 at 10:46 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > > Enable HDMI audio on RZ/{G2L,V2L} SMARC EVK. > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > > Thanks for your patch! > > > > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc-pinfunction.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc-pinfunction.dtsi > > > @@ -143,6 +143,13 @@ ssi0_pins: ssi0 { > > > <RZG2L_PORT_PINMUX(45, 3, 1)>; /* RXD */ > > > }; > > > > > > + ssi1_pins: ssi1 { > > > + pinmux = <RZG2L_PORT_PINMUX(46, 0, 1)>, /* BCK */ > > > + <RZG2L_PORT_PINMUX(46, 1, 1)>, /* RCK */ > > > + <RZG2L_PORT_PINMUX(46, 2, 1)>, /* TXD */ > > > + <RZG2L_PORT_PINMUX(46, 3, 1)>; /* RXD */ > > > > RXD/I2S2_SDIN is not wired on the carrier board. > > OK to drop it? > > > > The rest LGTM (but I'm no audio bindings expert). > The below comment is for RZ/G2LC SoC, where switch postion determines whether ssi0 signal is connected to Audio codec or to the HDMI audio. > Is dt binding check allows conditional macros? > > Based on switch position audio signal ssi0 is routed to Audio codec Or routed to HDMI audio > port > > The former one does not use graph where as latter one uses audio graph How do I describe this in > bindings? > > like dts, something like below supported in dt bindings?? > > #if X > Audio codec > #else > HDMI Audio > #endif > > Cheers, > Biju