Hi Biju,
Thank you for the patch.
On Tue, Jul 09, 2024 at 02:51:41PM +0100, Biju Das wrote:
> Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L
> SoC, but has only DPI interface.
>
> While at it, add missing required property port@1 for RZ/G2L and RZ/V2L
> SoCs. Currently there is no user for the DPI interface and hence there
> won't be any ABI breakage for adding port@1 as required property for
> RZ/G2L and RZ/V2L SoCs.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> ---
> v1->v2:
> * Updated commit description related to non ABI breakage.
> * Added Ack from Conor.
> ---
> .../bindings/display/renesas,rzg2l-du.yaml | 32 +++++++++++++++++--
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml
> index 08e5b9478051..c0fec282fa45 100644
> --- a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml
> +++ b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml
> @@ -18,6 +18,7 @@ properties:
> compatible:
> oneOf:
> - enum:
> + - renesas,r9a07g043u-du # RZ/G2UL
> - renesas,r9a07g044-du # RZ/G2{L,LC}
> - items:
> - enum:
> @@ -60,9 +61,6 @@ properties:
> $ref: /schemas/graph.yaml#/properties/port
> unevaluatedProperties: false
>
> - required:
> - - port@0
> -
> unevaluatedProperties: false
>
> renesas,vsps:
> @@ -88,6 +86,34 @@ required:
>
> additionalProperties: false
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r9a07g043u-du
> + then:
> + properties:
> + ports:
> + properties:
> + port@0: false
> + port@1:
> + description: DPI
> +
> + required:
> + - port@1
Why do you use port@1 for the DPI output here, and not port@0 ?
> + else:
> + properties:
> + ports:
> + properties:
> + port@0:
> + description: DSI
> + port@1:
> + description: DPI
> +
> + required:
> + - port@0
> + - port@1
You're missing a blank line here.
> examples:
> # RZ/G2L DU
> - |
--
Regards,
Laurent Pinchart
