On Tue, Jul 23, 2024 at 03:27:00PM +0200, Marek Vasut wrote: > Various PCIe controllers that mux MSIs onto single IRQ line produce these > "IRQ%d: set affinity failed" warnings when entering suspend. Remove the > .irq_set_affinity callbacks and make sure they are NULL in all affected > controllers, so this warning in kernel/irq/msi.c is not triggered. > > This has been compile-tested only on all but the R-Car PCI controller. > > The clean ups are done per-driver so they can be easily reverted in case > they break something. > Whole series looks good to me (PCI controller specific patches). FWIW, Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> - Mani > Marek Vasut (15): > genirq/msi: Silence set affinity failed warning > PCI: aardvark: Silence set affinity failed warning > PCI: altera-msi: Silence set affinity failed warning > PCI: brcmstb: Silence set affinity failed warning > PCI: dwc: Silence set affinity failed warning > PCI: mediatek-gen3: Silence set affinity failed warning > PCI: mediatek: Silence set affinity failed warning > PCI: mobiveil: Silence set affinity failed warning > PCI: plda: Silence set affinity failed warning > PCI: rcar-host: Silence set affinity failed warning > PCI: tegra: Silence set affinity failed warning > PCI: vmd: Silence set affinity failed warning > PCI: xilinx-nwl: Silence set affinity failed warning > PCI: xilinx-xdma: Silence set affinity failed warning > PCI: xilinx: Silence set affinity failed warning > > drivers/pci/controller/dwc/pci-keystone.c | 7 ------- > drivers/pci/controller/dwc/pcie-designware-host.c | 12 +++--------- > .../pci/controller/mobiveil/pcie-mobiveil-host.c | 11 ++--------- > drivers/pci/controller/pci-aardvark.c | 10 ++-------- > drivers/pci/controller/pci-tegra.c | 10 ++-------- > drivers/pci/controller/pcie-altera-msi.c | 11 ++--------- > drivers/pci/controller/pcie-brcmstb.c | 11 ++--------- > drivers/pci/controller/pcie-mediatek-gen3.c | 13 +++---------- > drivers/pci/controller/pcie-mediatek.c | 11 ++--------- > drivers/pci/controller/pcie-rcar-host.c | 10 ++-------- > drivers/pci/controller/pcie-xilinx-dma-pl.c | 11 ++--------- > drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++--------- > drivers/pci/controller/pcie-xilinx.c | 9 ++------- > drivers/pci/controller/plda/pcie-plda-host.c | 11 ++--------- > drivers/pci/controller/vmd.c | 13 +------------ > include/linux/msi.h | 2 ++ > kernel/irq/msi.c | 2 +- > 17 files changed, 32 insertions(+), 133 deletions(-) > > Cc: "Krzysztof Wilczyński" <kw@xxxxxxxxx> > Cc: "Pali Rohár" <pali@xxxxxxxxxx> > Cc: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx> > Cc: Aleksandr Mishin <amishin@xxxxxxxxxx> > Cc: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx> > Cc: Anup Patel <apatel@xxxxxxxxxxxxxxxx> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx> > Cc: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx> > Cc: Damien Le Moal <dlemoal@xxxxxxxxxx> > Cc: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> > Cc: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx> > Cc: Jianjun Wang <jianjun.wang@xxxxxxxxxxxx> > Cc: Jim Quinlan <jim2101024@xxxxxxxxx> > Cc: Jingoo Han <jingoohan1@xxxxxxxxx> > Cc: Jisheng Zhang <Jisheng.Zhang@xxxxxxxxxxxxx> > Cc: Jon Hunter <jonathanh@xxxxxxxxxx> > Cc: Jonathan Derrick <jonathan.derrick@xxxxxxxxx> > Cc: Jonathan Hunter <jonathanh@xxxxxxxxxx> > Cc: Joyce Ooi <joyce.ooi@xxxxxxxxx> > Cc: Karthikeyan Mitran <m.karthikeyan@xxxxxxxxxxxxxx> > Cc: Kishon Vijay Abraham I <kishon@xxxxxxxxxx> > Cc: Koichiro Den <den@xxxxxxxxxxxxx> > Cc: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > Cc: Marc Zyngier <maz@xxxxxxxxxx> > Cc: Michal Simek <michal.simek@xxxxxxx> > Cc: Nicolas Saenz Julienne <nsaenz@xxxxxxxxxx> > Cc: Niklas Cassel <cassel@xxxxxxxxxx> > Cc: Nipun Gupta <nipun.gupta@xxxxxxx> > Cc: Nirmal Patel <nirmal.patel@xxxxxxxxxxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx> > Cc: Ryder Lee <ryder.lee@xxxxxxxxxxxx> > Cc: Shivamurthy Shastri <shivamurthy.shastri@xxxxxxxxxxxxx> > Cc: Siddharth Vadapalli <s-vadapalli@xxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx > Cc: linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-tegra@xxxxxxxxxxxxxxx > > -- > 2.43.0 > -- மணிவண்ணன் சதாசிவம்