Re: [PATCH v2 3/3] i2c: rcar: minor changes to adhere to coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> A newline was missing and closing braces of functions do not need a
> semicolon.

Can there be a need to offer such changes by separate update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n81


…
> +++ b/drivers/i2c/busses/i2c-rcar.c
> @@ -192,7 +192,7 @@ static int rcar_i2c_get_scl(struct i2c_adapter *adap)
>
>  	return !!(rcar_i2c_read(priv, ICMCR) & FSCL);
>
> -};
> +}
…

How do you think about to omit any blank lines at such source code places?

Regards,
Markus





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux