Hi Geert,
> > > static inline void riic_writeb(struct riic_dev *riic, u8 val, u8 offset)
> > > {
> > > writeb(val, riic->base + riic->info->regs[offset]);
> > > @@ -133,10 +135,14 @@ static int riic_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
> > > struct riic_dev *riic = i2c_get_adapdata(adap);
> > > struct device *dev = adap->dev.parent;
> > > unsigned long time_left;
> > > - int i;
> > > + int i, ret;
> > > u8 start_bit;
> > >
> > > - pm_runtime_get_sync(dev);
> > > + ret = pm_runtime_resume_and_get(dev);
> >
> > In principle I like the error message to be always checked and I
>
> s/message/condition/?
yes :-)
> > will always approve it. Whenever there is a return value, even
> > when we are sure it's always '0', it needs to be checked.
> >
> > I had lots of discussions in the past about this topic but I
> > haven't always found support. I'd love to have the ack from a
> > renesas maintainer here.
>
> I don't mind checking for the error here.
>
> >
> > > + if (ret) {
> > > + dev_err(dev, riic_rpm_err_msg);
>
> Do you need to print these error messages?
I don't think it's needed, indeed.
> AFAIU, this cannot happen anyway.
That's what I was saying earlier. It's just a different point of
view.
To be honest, I don't really mind.
Thanks,
Andi
> Ultimately, I expect the device driver that requested the transfer to
> handle failures, and print a message when needed.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
