On Mi, 2024-07-03 at 08:56 +0000, Biju Das wrote: > Hi Geert, > > Thanks for the feedback. > > > -----Original Message----- > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Sent: Wednesday, July 3, 2024 9:36 AM > > Subject: Re: [PATCH v5 4/4] arm64: dts: renesas: rz-smarc: Replace fixed regulator for USB VBUS > > > > Hi Biju, > > > > On Tue, Jul 2, 2024 at 8:01 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > > Replace the fixed regulator for USB VBUS and use the proper one that > > > controls regulator based on VBUS detection. > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > --- > > > v4->v5: > > > * Updated commit description. > > > > Thanks for the update! > > > > > --- a/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi > > > @@ -54,14 +54,6 @@ codec_dai: simple-audio-card,codec { > > > }; > > > }; > > > > > > - usb0_vbus_otg: regulator-usb0-vbus-otg { > > > - compatible = "regulator-fixed"; > > > - > > > - regulator-name = "USB0_VBUS_OTG"; > > > - regulator-min-microvolt = <5000000>; > > > - regulator-max-microvolt = <5000000>; > > > - }; > > > - > > > vccq_sdhi1: regulator-vccq-sdhi1 { > > > compatible = "regulator-gpio"; > > > regulator-name = "SDHI1 VccQ"; @@ -139,6 +131,9 @@ > > > &ohci1 { > > > > > > &phyrst { > > > status = "okay"; > > > + usb0_vbus_otg: regulator-vbus { > > > > The label is not really needed, is it? > > The label is used in usb2_phy0 node. > > vbus-supply = <&usb0_vbus_otg>; > > > > > > + regulator-name = "vbus"; > > > + }; > > > > Also, as the regulator-vbus subnode is required, perhaps it should be moved to the SoC- > > specific .dtsi? Or do you keep it here for board-specific control of the regulator name, i.e. to > > avoid conflicts? > > Yes, just to avoid conflicts. Later I can move to individual SoC specific dtsi's Alright, thanks! Applied to reset/next. [1/4] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document USB VBUS regulator https://git.pengutronix.de/cgit/pza/linux/commit/?id=f64f2d6fdda4 [2/4] reset: renesas: Add USB VBUS regulator device as child https://git.pengutronix.de/cgit/pza/linux/commit/?id=4068f22e4b47 [3/4] phy: renesas: phy-rcar-gen3-usb2: Control VBUS for RZ/G2L SoCs https://git.pengutronix.de/cgit/pza/linux/commit/?id=24843404efe4 [4/4] arm64: dts: renesas: rz-smarc: Replace fixed regulator for USB VBUS https://git.pengutronix.de/cgit/pza/linux/commit/?id=c1267e1afae6 regards Philipp