Hi Morimoto-san, Thanks for your patch! On Mon, Jun 24, 2024 at 2:16 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > Add sound support for R-Car V4M. > > Signed-off-by: Khanh Le <khanh.le.xr@xxxxxxxxxxx> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> The Sob-chain does not match the From:. Either there should be a "From: Khanh Le ..." at the top, or a "Co-developed-by: Khanh Le ..." before the "Signed-off-by: Khanh Le ...". https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > --- a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi > @@ -1464,6 +1471,67 @@ dmac2: dma-controller@e7351000 { > <&ipmmu_ds0 22>, <&ipmmu_ds0 23>; > }; > > + rcar_sound: sound@ec400000 { > + compatible = "renesas,rcar_sound-r8a779h0", "renesas,rcar_sound-gen4"; > + reg = <0 0xec400000 0 0x40000>, /* SSI_SDMC */ > + <0 0xec540000 0 0x1000>, /* SSIU */ > + <0 0xec541000 0 0x050>, /* SSI */ > + <0 0xec5a0000 0 0x020>; /* ADG */ No need for the comments, we have "reg-names" below... > + reg-names = "sdmc", "ssiu", "ssi", "adg"; > + clocks = <&cpg CPG_MOD 2926>, <&cpg CPG_MOD 2927>, <&audio_clkin>; > + clock-names = "ssiu.0", "ssi.0", "clkin"; > + /* #clock-cells is fixed */ > + #clock-cells = <0>; > + /* #sound-dai-cells is fixed */ > + #sound-dai-cells = <0>; The rest LGTM, so Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> If you tell me the correct author-chain, I can make these changes while queuing in renesas-devel for v6.11. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
