Hi Vinod, Thanks for the feedback. > -----Original Message----- > From: Vinod Koul <vkoul@xxxxxxxxxx> > Sent: Thursday, June 20, 2024 5:38 PM > Subject: Re: [PATCH v4 0/6] Add USB VBUS regulator for RZ/G2L > > On 16-06-24, 11:53, Biju Das wrote: > > As per RZ/G2L HW manual, VBUS enable can be controlled by the VBOUT > > bit of the VBUS Control Register(VBENCTL) register in the USBPHY > > Control. But this IP is in the Reset block. > > > > Reset driver exposes this register as regmap and instantiate the USB > > VBUS regulator device. Consumers(phy device) can use regulator APIs to > > control VBUS as controlling is done in the atomic context. > > > > We need to have merge strategy which subsytem will apply this patches > > as it involves multiple subsystems Reset, Regulator, PHY, DT and > > Renesas SoC?? > > Why is there a dependency.. why cant they go thru respective trees? In this series, only regulator driver changes has no dependency. PHY driver (phy-rcar-gen3-usb2.c) has a dependency on new regulator consumer API regulator_hardware_enable(), Without this it will lead to compilation error. USB PHY ctrl driver(reset-rzg2l-usbphy-ctrl.c) instantiate and bind regulator driver(renesas-usb-vbus-regulator.c). If regulator driver is not there means, USB PHY ctrl driver probe() fails, that will break existing USB functionality. Cheers, Biju
