Hello Manivannan,
Thank you for your review!
> From: Manivannan Sadhasivam, Sent: Tuesday, June 18, 2024 4:09 PM
>
> On Tue, Jun 11, 2024 at 09:50:56PM +0900, Yoshihiro Shimoda wrote:
<snip>
> > @@ -221,6 +257,10 @@ static void rcar_gen4_pcie_unprepare(struct rcar_gen4_pcie *rcar)
> >
> > static int rcar_gen4_pcie_get_resources(struct rcar_gen4_pcie *rcar)
> > {
> > + rcar->phy_base = devm_platform_ioremap_resource_byname(rcar->pdev, "phy");
> > + if (IS_ERR(rcar->phy_base))
> > + return PTR_ERR(rcar->phy_base);
> > +
>
> I failed to spot this in earlier reviews. Since this 'phy' region is only
> applicable for r8a779g0, wouldn't this fail on other platforms?
This will not fail on other platforms because the dtsi file of the other platform (r8a779f0.dtsi)
already has the 'phy' region in the first commit which I added PCIe nodes:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/renesas/r8a779f0.dtsi?h=v6.10-rc4&id=183a709d3719e5c9919a6f12c86c0a3e088b712d
Best regards,
Yoshihiro Shimoda
