On Mon, Jun 10, 2024 at 6:48 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > As soon as the reset controller is registered, it could be used by a > reset consumer. That means hardware setup to be done first and then the > registration of the reset controller. So move the registration of reset > controller at the end of probe(). > > While at it, fix the issue that the reset is not re-asserted in case > devm_reset_controller_register() fails and also use goto statements to > simplify the error path in probe(). > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > --- > v1->v2: > * Updated commit header and description > * Moved reset controller registration at the end of the probe() > * Fixed the issue that the reset is not re-asserted in case > devm_reset_controller_register() fails > * Used goto statements to simplify the error path in probe(). > * Restored the blank line before devm_reset_controller_register(). Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds