Hi Uwe, > -----Original Message----- > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> > Sent: Friday, June 14, 2024 5:03 PM > Subject: Re: [PATCH] pwm: Fix namespace error > > Hello, > > On Fri, Jun 14, 2024 at 03:44:27PM +0000, Biju Das wrote: > > > -----Original Message----- > > > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> > > > Subject: Re: [PATCH] pwm: Fix namespace error > > > > > > On Fri, Jun 14, 2024 at 04:12:33PM +0100, Biju Das wrote: > > > > Fix namespace error due to typo by replacing USB_STORAGE->PWM. > > > > > > > > Fixes: aeb9cedc87a2 ("pwm: Make use of a symbol namespace for the > > > > core") > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > > > > I found that issue locally, too, but obviously failed to squash this > > > change into the commit. How embarrassing. > > > > Yes, It make sense to squash the commit before it lands to linus tree. > > I squashed your patch into mine now and added: > > Thanks to Biju Das for pointing out a cut'n'paste failure in my > initial patch. > > to the commit log. > > Is this ok for you? If not, keeping the fix separate would be ok for me, too. Yes, It is ok, if you just squash the patch. I don't mind, if you remove "Thanks to Biju Das for pointing out a cut'n'paste failure in my initial patch." as you already found the issue locally. Cheers, biju