Hi Prabhakar, > > - can't we use .enable/.disable in regulator_ops for handling pwen? > > Then we could simply use regulator_en/disable in the code and be future > > proof when other SDHI instances have other kinds of regulators (unless > > I am mising something) > > > Ok let me check on this and get back. Thanks! > > - what about not using regmap and use set/get_voltage and friends? My > > concern is that other "new" registers might appear in the future and > > it will be cumbersome to handle the scattered IO regions. > > > I'll have to do some reading on this. Can you please point me to any > example driver which does not use regmap. Sure thing! ~/Kernel/linux/drivers/regulator$ grep -L regmap $(grep -l devm_regulator_register *.c) aat2870-regulator.c ab8500.c ab8500-ext.c ad5398.c cros-ec-regulator.c da903x-regulator.c db8500-prcmu.c dummy.c fixed.c gpio-regulator.c isl6271a-regulator.c lp3971.c lp3972.c max1586.c max8660.c max8925-regulator.c max8952.c max8997-regulator.c max8998.c mc13783-regulator.c mc13892-regulator.c mtk-dvfsrc-regulator.c pcap-regulator.c pwm-regulator.c qcom-rpmh-regulator.c qcom_rpm-regulator.c qcom_smd-regulator.c scmi-regulator.c stm32-pwr.c ti-abb-regulator.c tps6507x-regulator.c tps6524x-regulator.c twl6030-regulator.c twl-regulator.c vctrl-regulator.c > > That said, having a regulator is not a quirk in my book. I'd think > > 'struct renesas_sdhi' is the proper place. Or? > > > Ok, I will move them out of quirks. Cool! Happy hacking, Wolfram
Attachment:
signature.asc
Description: PGP signature
