On Thu, May 30, 2024 at 7:42 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Add support to configure bias-disable, bias-pull-up, and bias-pull-down > properties of the pin. > > Two new function pointers, hw_to_bias_param() and bias_param_to_hw(), are > introduced in the struct rzg2l_pinctrl_data to configure bias settings, > as the values in the PUPD register differ when compared to the RZ/G2L > family and the RZ/V2H(P) SoC. > > Value | RZ/G2L | RZ/V2H > --------------------------------- > 00b: | Bias Disabled | Pull up/down disabled > 01b: | Pull-up | Pull up/down disabled > 10b: | Pull-down | Pull-down > 11b: | Prohibited | Pull-up > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > --- > v2->v3 > - Updated commit message > - Renamed get_bias_param -> hw_to_bias_param > - Renamed get_bias_val -> bias_param_to_hw > - Dropped un-necessary block {} > - Now reading arg before calling hw_to_bias_param() Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds