Hi Hans,
Gentle ping on this patch.
On 2024-04-17 14:02:30 +0200, Niklas Söderlund wrote:
> Some R-Car SoCs are capable of capturing RAW10. Add support for it
> using the V4L2_PIX_FMT_Y10 pixel format, which I think is the correct
> format to express RAW10 unpacked to users.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> * Changes since RFC
> - Fix spelling in rcar-vin.h
> ---
> drivers/media/platform/renesas/rcar-vin/rcar-core.c | 1 +
> drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 12 ++++++++++++
> drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c | 8 ++++++++
> drivers/media/platform/renesas/rcar-vin/rcar-vin.h | 4 +++-
> 4 files changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> index 809c3a38cc4a..e9675cb8faa2 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> @@ -1279,6 +1279,7 @@ static const struct rvin_info rcar_info_r8a779a0 = {
> .use_mc = true,
> .use_isp = true,
> .nv12 = true,
> + .raw10 = true,
> .max_width = 4096,
> .max_height = 4096,
> };
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> index e2c40abc6d3d..dd290054dfe7 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> @@ -123,7 +123,9 @@
> /* Video n Data Mode Register bits */
> #define VNDMR_A8BIT(n) (((n) & 0xff) << 24)
> #define VNDMR_A8BIT_MASK (0xff << 24)
> +#define VNDMR_RMODE_RAW10 (2 << 19)
> #define VNDMR_YMODE_Y8 (1 << 12)
> +#define VNDMR_YC_THR (1 << 11)
> #define VNDMR_EXRGB (1 << 8)
> #define VNDMR_BPSM (1 << 4)
> #define VNDMR_ABIT (1 << 2)
> @@ -780,6 +782,9 @@ static int rvin_setup(struct rvin_dev *vin)
> case MEDIA_BUS_FMT_Y8_1X8:
> vnmc |= VNMC_INF_RAW8;
> break;
> + case MEDIA_BUS_FMT_Y10_1X10:
> + vnmc |= VNMC_INF_RGB666;
> + break;
> default:
> break;
> }
> @@ -888,6 +893,9 @@ static int rvin_setup(struct rvin_dev *vin)
> dmr = 0;
> }
> break;
> + case V4L2_PIX_FMT_Y10:
> + dmr = VNDMR_RMODE_RAW10 | VNDMR_YC_THR;
> + break;
> default:
> vin_err(vin, "Invalid pixelformat (0x%x)\n",
> vin->format.pixelformat);
> @@ -1270,6 +1278,10 @@ static int rvin_mc_validate_format(struct rvin_dev *vin, struct v4l2_subdev *sd,
> if (vin->format.pixelformat != V4L2_PIX_FMT_GREY)
> return -EPIPE;
> break;
> + case MEDIA_BUS_FMT_Y10_1X10:
> + if (vin->format.pixelformat != V4L2_PIX_FMT_Y10)
> + return -EPIPE;
> + break;
> default:
> return -EPIPE;
> }
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
> index bb4b07bed28d..e7298688541d 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
> @@ -86,6 +86,10 @@ static const struct rvin_video_format rvin_formats[] = {
> .fourcc = V4L2_PIX_FMT_GREY,
> .bpp = 1,
> },
> + {
> + .fourcc = V4L2_PIX_FMT_Y10,
> + .bpp = 4,
> + },
> };
>
> const struct rvin_video_format *rvin_format_from_pixel(struct rvin_dev *vin,
> @@ -106,6 +110,10 @@ const struct rvin_video_format *rvin_format_from_pixel(struct rvin_dev *vin,
> if (!vin->info->nv12 || !(BIT(vin->id) & 0x3333))
> return NULL;
> break;
> + case V4L2_PIX_FMT_Y10:
> + if (!vin->info->raw10)
> + return NULL;
> + break;
> default:
> break;
> }
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-vin.h b/drivers/media/platform/renesas/rcar-vin/rcar-vin.h
> index 997a66318a29..f87d4bc9e53e 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-vin.h
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-vin.h
> @@ -151,7 +151,8 @@ struct rvin_group_route {
> * @model: VIN model
> * @use_mc: use media controller instead of controlling subdevice
> * @use_isp: the VIN is connected to the ISP and not to the CSI-2
> - * @nv12: support outputing NV12 pixel format
> + * @nv12: support outputting NV12 pixel format
> + * @raw10: support outputting RAW10 pixel format
> * @max_width: max input width the VIN supports
> * @max_height: max input height the VIN supports
> * @routes: list of possible routes from the CSI-2 recivers to
> @@ -163,6 +164,7 @@ struct rvin_info {
> bool use_mc;
> bool use_isp;
> bool nv12;
> + bool raw10;
>
> unsigned int max_width;
> unsigned int max_height;
> --
> 2.44.0
>
--
Kind Regards,
Niklas Söderlund
