On 5/29/24 10:07 PM, Paul Barker wrote:
[...]
>>> We can reduce code duplication in ravb_rx_gbeth().
>>>
>>> Signed-off-by: Paul Barker <paul.barker.ct@xxxxxxxxxxxxxx>
>> [...]
>>
>>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
>>> index 7df7d2e93a3a..c9c5cc641589 100644
>>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>>> @@ -817,47 +817,54 @@ static int ravb_rx_gbeth(struct net_device *ndev, int budget, int q)
>>> stats->rx_missed_errors++;
>>> } else {
>>> die_dt = desc->die_dt & 0xF0;
>>> + skb = ravb_get_skb_gbeth(ndev, entry, desc);
>>> switch (die_dt) {
>>
>> Why not do instead (as I've asked you alraedy):
Already. :-)
>>
>> case DT_FSTART:
>> priv->rx_1st_skb = skb;
>> fallthrough;
>
> I've avoided that change to keep patch 7/7 simpler (as we have to move
> the assignment of skb later in that patch). I can change this if you
> want though.
Oh, then please keep it as is! :-)
[...]
> Thanks for the review!
MBR, Sergey
