Hi Andy,
On Thu, May 30, 2024 at 11:03 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> Mon, May 13, 2024 at 01:59:03PM +0200, Geert Uytterhoeven kirjoitti:
> > On Sat, May 4, 2024 at 3:14 PM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote:
> > You missed one trivial conversion, presumably because no error handling
> > and thus no of_node_put() is involved?
>
> Nothing is missed. The below is a redundant change.
>
> ...
>
> > - for_each_child_of_node(np, child) {
> > + for_each_child_of_node_scoped(np, child) {
> > if (of_property_count_u32_elems(child, RZN1_PINS_PROP) > 0)
> > count++;
> > }
> >
> > If you prefer not to include this
>
> I prefer this not to be included as it will give a misleading signals to the
> use of the original API(s).
Thank you for reminding me to send this out as a separate patch :-)
https://lore.kernel.org/r/c0a28f466c42d5d59c7fadfa1fd05fd512d43b6f.1717060708.git.geert+renesas@xxxxxxxxx
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
