Hi Stephen, On Wed, May 29, 2024 at 9:56 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > Quoting Geert Uytterhoeven (2024-05-29 02:35:09) > > A global spinlock can be initialized automatically with > > DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). > > > > Suggested-by: Ye Bin <yebin10@xxxxxxxxxx> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > Shouldn't this be first so that the previous patch can use the > initialized spinlock? Order of the patches doesn't matter. r8a77970_cpg_mssr_init() in the R-Car V3M sub-driver calls into rcar_gen3_cpg_init() in the Gen3 family sub-driver, which initialized the spinlock. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds