On Fri, May 10, 2024 at 09:38:10AM +0200, Romain Gantois wrote: > From: Serge Semin <fancer.lancer@xxxxxxxxx> > > A pcs_init() callback will be introduced to stmmac in a future patch. This > new function will be called during the hardware initialization phase. > Instead of separately initializing XPCS and PCS components, let's group all > PCS-related hardware initialization logic in the current > stmmac_xpcs_setup() function. > > Rename stmmac_xpcs_setup() to stmmac_pcs_setup() and move the conditional > call to stmmac_xpcs_setup() inside the function itself. > > Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx> > Co-developed-by: Romain Gantois <romain.gantois@xxxxxxxxxxx> stmmac_pcs_init() looks weird in this patch, but the reason is set out here. So: Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
