Hi Jacopo, Thank you for the patch. On Fri, May 03, 2024 at 05:51:24PM +0200, Jacopo Mondi wrote: > The max9286 driver supports multiple output formats but only a single > one is reported through the .enum_mbus_code operation. > > Fix that. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > --- > drivers/media/i2c/max9286.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index d685d445cf23..5321238cad60 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -914,10 +914,10 @@ static int max9286_enum_mbus_code(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_mbus_code_enum *code) > { > - if (code->pad || code->index > 0) > + if (code->pad || code->index >= ARRAY_SIZE(max9286_formats)) > return -EINVAL; > > - code->code = MEDIA_BUS_FMT_UYVY8_1X16; > + code->code = max9286_formats[code->index].code; > > return 0; > } -- Regards, Laurent Pinchart