On Wed, May 01, 2024 at 08:56:08PM +0800, Peng Fan (OSS) wrote: > @@ -1224,8 +1221,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np, > grp->pin_conf = devm_kcalloc(dev, npins, sizeof(*grp->pin_conf), GFP_KERNEL); > > if (!grp->pins || !grp->pin_conf) { > - ret = -ENOMEM; > - goto out_put_node; > + return -ENOMEM; > } You could delete the curly braces as well. regards, dan carpenter