On Wed, Apr 24, 2024 at 06:33:30PM +0200, Romain Gantois wrote: > Hi Serge, > > On Wed, 24 Apr 2024, Serge Semin wrote: > > > Once again. There is a ready-to-use stmmac_xpcs_setup() method. Which > > is currently intended for the XPCS setups. Let's collect all the > > PCS-related stuff in a single place there. That will make code cleaner > > and easier to read. This was discussed on v3: > > > > https://lore.kernel.org/netdev/42chuecdt7dpgm6fcrtt2crifvv5hflmtnmdrw5fvk3r7pwjgu@hlcv56dbeosf/ > > > > You agreed to do that, but just ignored in result. I'll repeat what I > > said in v3: > > Yeah sorry I took a quick look at your merged patches and thought that > stmmac_xpcs_setup() had been repurposed in the meantime, but it seems like I was > just confused about that. > > > It doesn't look as that much hard thing to do, but will cause having a > > better readable code by providing a single coherent function for all > > PCS'es. > > Sure, I'll get to it in v5. Awesome! Thanks. -Serge(y) > > Thanks, > > -- > Romain Gantois, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
