Hi Sean,
On Tue, Apr 9, 2024 at 7:51 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> Initialize cpu_mitigations to CPU_MITIGATIONS_OFF if the kernel is built
> with CONFIG_SPECULATION_MITIGATIONS=n, as the help text quite clearly
> states that disabling SPECULATION_MITIGATIONS is supposed to turn off all
> mitigations by default.
>
> │ If you say N, all mitigations will be disabled. You really
> │ should know what you are doing to say so.
>
> As is, the kernel still defaults to CPU_MITIGATIONS_AUTO, which results in
> some mitigations being enabled in spite of SPECULATION_MITIGATIONS=n.
>
> Fixes: f43b9876e857 ("x86/retbleed: Add fine grained Kconfig knobs")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
Thanks for your patch, which is now commit f337a6a21e2fd67e
("x86/cpu: Actually turn off mitigations by default
for SPECULATION_MITIGATIONS=n") in v6.9-rc4.
This causes the following suspicious messages on R-Car H3:
CPU features: kernel page table isolation forced OFF by mitigations=off
spectre-v4 mitigation disabled by command-line option
spectre-v2 mitigation disabled by command line option
spectre-v2 mitigation disabled by command line option
and R-Car V4H:
CPU features: kernel page table isolation forced OFF by mitigations=off
spectre-v4 mitigation disabled by command-line option
spectre-bhb mitigation disabled by command line option
spectre-bhb mitigation disabled by command line option
Interestingly, no mitigations are disabled on the command-line.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
