Hi, Geert, On 14.03.2024 18:01, Geert Uytterhoeven wrote: > On Thu, Mar 7, 2024 at 3:07 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote: >> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> >> >> Instantiate power domains for the currently enabled IPs of R9A08G045 SoC. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> >> --- >> >> Change in v2: >> - used DEF_REG_CONF() to describe register offests and bits >> - updated MSTOP bitmask for ddr domain >> - updated MSTOP config for oftde_ddr >> - kept the same description for gic as the CPG_BUS_ACPU_MSTOP register >> documentation in the latest HW manual version is wrong and it will be >> fixed; proper description for GIC is located in "Registers for Module >> Standby Mode" table >> - haven't added watchdog domain (was missing in v1, too, by mistake) as >> the watchdog restart handler will fail w/o patch [1]; with this pm domain >> support the watchdog will fail to probe; not sure what is the best >> option until [1] will be integrated >> >> [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240228083253.2640997-10-claudiu.beznea.uj@xxxxxxxxxxxxxx > > I guess we'll have to wait until that dependency is integrated, I opt for this option to not break the reset support currently integrated. I don't have any feedback from maintainers yet on [1], though. I don't know how long it will take. Thank you, Claudiu Beznea > or use an immutable branch? > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds