Hi Claudiu, Thank you for the review. On Thu, Mar 28, 2024 at 8:13 AM claudiu beznea <claudiu.beznea@xxxxxxxxx> wrote: > > > > On 28.03.2024 10:02, claudiu beznea wrote: > > Hi, Prabhakar, > > > > On 27.03.2024 00:28, Prabhakar wrote: > >> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > >> > >> On the RZ/G2L SoC, the PFCWE bit controls writing to PFC registers. > >> However, on the RZ/V2H(P) SoC, the PFCWE (REGWE_A on RZ/V2H) bit controls > >> writing to both PFC and PMC registers. To accommodate these differences > >> across SoC variants, introduce set_pfc_mode() and pm_set_pfc() function > >> pointers. > > > > I think the overall code can be simplified if you add 1 function that does > > the lock/unlock for PWPR. See patch 13. > > I meant to say one function for lock and one for unlock. > I agree, let me remodel it that way. Cheers, Prabhakar
