On Wed, Mar 27, 2024 at 4:09 AM kernel test robot <lkp@xxxxxxxxx> wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git master > head: 5e36d764b5dfcddd54895d9b6dc392eaaba17d6a > commit: 61d4f86ef0002b12ed52d2dc7a08c23b53798766 [23/30] Revert "scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices" > config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240327/202403271144.JmvFogog-lkp@xxxxxxxxx/config) > compiler: aarch64-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240327/202403271144.JmvFogog-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202403271144.JmvFogog-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > > >> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3548:10: error: 'sas_ata_sdev_attr_group' undeclared here (not in a function) > 3548 | &sas_ata_sdev_attr_group, > | ^~~~~~~~~~~~~~~~~~~~~~~ > -- > >> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:2933:10: error: 'sas_ata_sdev_attr_group' undeclared here (not in a function) > 2933 | &sas_ata_sdev_attr_group, > | ^~~~~~~~~~~~~~~~~~~~~~~ This is due to reverting commit b4d3ddd2df7531e3 ("scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices") in scsi-mkp/for-next, which caused other build failures, cfr. https://lore.kernel.org/r/CAMuHMdWxVbT=f+kZ58urwGhYD9RfBnu7u8oLAyrx_riU8OGt0w@xxxxxxxxxxxxxx > vim +/sas_ata_sdev_attr_group +3548 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > > 62ac8ccbb819e35 Bart Van Assche 2021-10-12 3546 > a23971e8ff0c43d Igor Pylypiv 2024-03-07 3547 static const struct attribute_group *sdev_groups_v2_hw[] = { > a23971e8ff0c43d Igor Pylypiv 2024-03-07 @3548 &sas_ata_sdev_attr_group, > a23971e8ff0c43d Igor Pylypiv 2024-03-07 3549 NULL > a23971e8ff0c43d Igor Pylypiv 2024-03-07 3550 }; > a23971e8ff0c43d Igor Pylypiv 2024-03-07 3551 > > :::::: The code at line 3548 was first introduced by commit > :::::: a23971e8ff0c43d47e1772b62c2916ff0b768fca scsi: hisi_sas: Add libsas SATA sysfs attributes group > > :::::: TO: Igor Pylypiv <ipylypiv@xxxxxxxxxx> > :::::: CC: Martin K. Petersen <martin.petersen@xxxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds