Hi Biju, On Mon, Mar 25, 2024 at 4:21 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > > -----Original Message----- > > From: Prabhakar <prabhakar.csengg@xxxxxxxxx> > > Sent: Friday, March 22, 2024 2:44 PM > > Subject: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt- > > names' > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > This commit adds support to validate the 'interrupts' and 'interrupt-names' > > properties for every supported SoC. This ensures proper handling and configuration of interrupt- > > related properties across supported platforms. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > v3->v4 > > - Reverted back to v2 version of the patch. > > - Used suggestion from Krzysztof for interrupts > > - Restored RB tag from Geert > > > > v2->v3 > > - Listed interrupts and interrupt-names for every SoC in if check > > --- > > .../bindings/serial/renesas,scif.yaml | 73 ++++++++++++++----- > > 1 file changed, 55 insertions(+), 18 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > index af72c3420453..eb2aa5e75e02 100644 > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > @@ -86,11 +86,6 @@ properties: > > oneOf: > > - items: > > - description: A combined interrupt > > - - items: > > - - description: Error interrupt > > - - description: Receive buffer full interrupt > > - - description: Transmit buffer empty interrupt > > - - description: Break interrupt > > - items: > > - description: Error interrupt > > - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: > > - description: Break interrupt > > - description: Data Ready interrupt > > - description: Transmit End interrupt > > + minItems: 4 > > I think here minItems is 1 as it is either 1 or 4 or 6 > minItems 1 case is already handled above. Cheers, Prabhakar
