RE: [PATCH v4 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Tuesday, March 19, 2024 8:44 AM
> Subject: Re: [PATCH v4 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
> 
> Hi Biju,
> 
> On Mon, Mar 18, 2024 at 6:33 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > The RZ/G2L family SoCs has 10 pipe buffers compared to 16 pipe buffers
> > on RZ/A2M. Update the pipe configuration for RZ/G2L family SoCs and
> > use family SoC specific compatible to handle this difference.
> >
> > The pipe configuration of RZ/G2L is same as
> > usbhsc_rzg2l_default_pipe[], so select the default pipe configuration
> > for RZ/G2L SoCs by setting .has_new_pipe_configs to zero.
> >
> > Add SoC specific compatible to OF table to avoid ABI breakage with old
> > DTB. To optimize memory usage the SoC specific compatible will be
> > removed later.
> >
> > Based on the patch in BSP by Huy Nguyen <huy.nguyen.wh@xxxxxxxxxxx>
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v3->v4:
> >  * Credit  Huy Nguyen's work in the commit message and dropped his name
> >    from Signed-off-by tag.
> >  * Selection of usbhsc_rzg2l_default_pipe[] by setting the variable
> >    has_new_pipe_configs to zero.
> >  * Updated commit description.
> 
> Thanks for the update!
> 
> >  * Dropped the check 'priv->dparam.pipe_configs' as it is same as
> >    checking !has_new_pipe_configs.
> 
> I disagree: it is used to specify the pipe config through platform data on non-DT platforms.  There
> don't seem to be any upstream SH platforms doing that, though.

You are correct.

> 
> > --- a/drivers/usb/renesas_usbhs/common.c
> > +++ b/drivers/usb/renesas_usbhs/common.c
> 
> > @@ -642,7 +658,7 @@ static int usbhs_probe(struct platform_device *pdev)
> >         if (usbhs_get_dparam(priv, has_new_pipe_configs)) {
> >                 priv->dparam.pipe_configs = usbhsc_new_pipe;
> >                 priv->dparam.pipe_size = ARRAY_SIZE(usbhsc_new_pipe);
> > -       } else if (!priv->dparam.pipe_configs) {
> > +       } else {
> 
> Hence I'd rather drop this check.

Ok, will restore the check.

Cheers,
Biju

> 
> >                 priv->dparam.pipe_configs = usbhsc_default_pipe;
> >                 priv->dparam.pipe_size = ARRAY_SIZE(usbhsc_default_pipe);
> >         }




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux