Hi Thomas, > -----Original Message----- > From: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Sent: Thursday, March 14, 2024 8:59 AM > Subject: RE: [PATCH v2 5/5] irqchip/renesas-rzg2l: Use TIEN for enable/disable > > On Wed, Mar 13 2024 at 15:59, Biju Das wrote: > >> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx> IOW, it's zero functional > >> change and completely unrelated to the above blurb. > > > > There is functional change. During disable, TINT source and TIEN > > cleared together > > > > reg &= ~(TSSEL_MASK << TSSEL_SHIFT(tssr_offset)); > > > > During Enable, TINT source and TIEN set together > > > > reg |= (TIEN | tint) << TSSEL_SHIFT(tssr_offset); > > > > This patch avoids modifying TINT source register which avoids hw race > > as mentioned by hardware team. According to them we should not set > > TINT source and TIEN together. > > Can you please split this into two pieces? > > 1) The fix itself at both places > > 2) The consolidation > > That way it's obvious what this is doing. I really missed that subtle change. OK, will split this patch into two. Thanks, Biju
